New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid warning on clang #16438
Avoid warning on clang #16438
Conversation
Use () instead of {} when initializing atomic to avoid a warning from clang because of how the symbol ATOMIC_FLAG_INIT is defined.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
This should substantially decrease the warnings from the clang build. |
-1 Tested at: 346cf6c The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
There was error running material budget tests. The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
The test failures are unrelated to this change. |
Use () instead of {} when initializing atomic to avoid a warning
from clang because of how the symbol ATOMIC_FLAG_INIT is defined.