Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning on clang #16438

Merged
merged 1 commit into from Nov 3, 2016
Merged

Conversation

Dr15Jones
Copy link
Contributor

Use () instead of {} when initializing atomic to avoid a warning
from clang because of how the symbol ATOMIC_FLAG_INIT is defined.

Use () instead of {} when initializing atomic to avoid a warning
from clang because of how the symbol ATOMIC_FLAG_INIT is defined.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16157/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

This should substantially decrease the warnings from the clang build.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

-1

Tested at: 346cf6c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1f6ae77
59dec3f
b2fdefd
30dcccb
e95e89f
538c500
dbf6ebf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16438/16157/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16438/16157/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16438/16157/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test testRecoMETMETProducers had ERRORS

  • Material budget:

There was error running material budget tests.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1f6ae77
59dec3f
b2fdefd
30dcccb
e95e89f
538c500
dbf6ebf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16438/16157/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16438/16157/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2016

@Dr15Jones
Copy link
Contributor Author

The test failures are unrelated to this change.

@davidlange6 davidlange6 merged commit c75cfae into cms-sw:CMSSW_8_1_X Nov 3, 2016
@Dr15Jones Dr15Jones deleted the avoidClangWarnings branch November 9, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants