Cleanup of Old MVA assignment / kill dead code / bugfixes

[lgray]

Built ontop of 700pre8 + patches, can rebase if needed.

Fix assignment of electron cluster and improve agreement of "mva" variable, you can see the improvement in agreement between mva values for (tracker-Driven && ECAL-Driven) electrons. The old mva-id isn't cut on anywhere in the ged reconstruction, so it is purely there for comparison with the old electrons / cosmetics.

Removed a few hundred lines of dead code from PFEGammaAlgo.cc/.h, none of it was called so this is purely cosmetic.

Fixed yet another EB/EE mixing bug, fixed a bug where clusters were being double counted.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

Cleanup of Old MVA assignment + kill dead code

It involves the following packages:

RecoParticleFlow/PFProducer

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1644/1552/summary.html

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1644/1565/summary.html

[slava77]

@slava77 working on it

[slava77]

Test results for 761de18 done in CMSSW_7_0_X_2013-12-05-0200 as sign277

Normal mode: changes are only in gedGsfElectron mvaInput_earlyBrem and mvaOutput_mva.

mvaInput_earlyBrem changes seem a bit more than epsilon.
See, e.g. the change for gamma-35GeV sample

The downstream effect of the above change is visible in the mva output. e.g., same sample

[slava77]

GED mode:
the mva changes are visible at the same level, as expected.

In addition, there are changes in the particle content (more PF candidates assigned as electrons, more visible in background or photon samples)

e.g. gamma35 sample eta of pfCandidates assigned to electrons, increase of ~5%, mostly in EE

Shapes of the distributions (other than mva) didn't change appreciably.

[slava77]

Lindsey,

are these increases in electron assignments to pfcandidates expected (the effect seems to be 5-10%, enhanced in events with real photons)?

[cmsbuild]

Pull request #1644 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

[lgray]

@slava77 Fixed the bug for assigning the early brem flag. Should be fairly similar now. I also included a patch to prevent proto-EGCandidates from getting merged if they both have a GSF track and clusters. This may also solve the problem of the crash that you sent an email about.

[cmsbuild]

Pull request #1644 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #1644 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

[slava77]

+1

Comparisons, based on 4261d3f in CMSSW_7_0_X_2013-12-05-0200 (sign277a)

Regular mode first:

• generally small changes
• PFEGammaAlgo::mergeROsByAnyLink: PFEGammaProducer:particleFlowEGamma warning is gone (good)
• earlyBrem variable now has values at -1
• changes are only in particleFlowEGamma|logErrorHarvester|gedGsfElectrons|gedPhotons

Most visible changes are in gamma10 , which has the most sensitivity thanks for being near threshold.
Diffs are visible only for low R9 (<0.6)

Electron Pt 35: the only noticeable drop is in the overlap region (eta~1.5),

GED Mode
In general, changes are as expected.

• Changes in gamma pt=10 sample are the most visible:
  • ~10% drop in golden electrons, almost matching increase in showering
• other samples, esp fake-dominated have reduced yields of photons, mostly at low R9

[slava77]

forgot to mention: this PR fixes
"Assertion `bclus.hitsAndFractions().at(0).first.subdetId()==EcalBarrel' failed."
crash in
RECODreHLT jobs failed due to the EcalClusterLocal error.
http://cms-project-relval.web.cern.ch/cms-project-relval/failures/CMSSW_7_0_0_pre9/standard_2/RunJet2012C__RelVal_jet2012C_Job1.tar.gz

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1644/1686/summary.html