Fix 2017 design workflow for '-i all' #16460
Conversation
…h the input dataset has not been set
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
On the other hand, maybe, in addition, we should update the |
|
GEN-SIM for HCAL should be stable. How about pixel? |
|
Ah, I see you said pixel isn't expected to stabilize until after pre16. I think we should wait until the whole detector is stable. |
|
To my understanding pixel should be final on pre16 (but don't take this as an authoritative statement). |
|
If we expect to regenerate gen-sim in pre16, then updating gensim input for Phase 1 relvals can be done later |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
1 similar comment
|
+1 |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pdmv-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Yes, the gen-sim for pre16 should be regenerated (because of FPix material updates). |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
When introducing the 2017 design workflow in #15994, I missed the fact that with
runTheMatrix.py -i allthe input dataset will be queried even if thedefaultDataSet['2017Design']is set to empty string. It turns out that all other workflows that havedefaultDataSetset to empty string are2023workflows, and for them the input dataset query is explicitly disabled.The proposed fix is to disable the input dataset query for all workflows to which
defaultDataSetis set to empty string.Tested in CMSSW_8_1_X_2016-11-03-1100. Expecting to fix
runTheMatrix.py -l 10424.0 -i all, no changes expected to anything else.Thanks to @smuzaffar for reporting the problem.
@smuzaffar @kpedro88