Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assert in OuterHitPhiPrediction.h #16462

Merged
merged 1 commit into from Nov 4, 2016
Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Nov 4, 2016

remove assert that can fail for straight-line

to fix https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1488.html
and more

note: this assert has been already removed in 810

remove assert that can fail for straight-line
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2016

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/TkTrackingRegions

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@VinInn VinInn changed the title Update OuterHitPhiPrediction.h remove assert in OuterHitPhiPrediction.h Nov 4, 2016
@VinInn
Copy link
Contributor Author

VinInn commented Nov 4, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16193/console

@davidlange6
Copy link
Contributor

@VinInn - better without "type"..

otherwise, did something change in the last few 80x builds to trigger this problem? (or just bad luck today)

@VinInn
Copy link
Contributor Author

VinInn commented Nov 4, 2016

@davidlange6 not to my knowledge

@VinInn
Copy link
Contributor Author

VinInn commented Nov 4, 2016

wbm says that mag field was 0.294 Tesla in the affected runs

@davidlange6
Copy link
Contributor

ah.. that can help explain it

On Nov 4, 2016, at 9:48 AM, Vincenzo Innocente notifications@github.com wrote:

wbm says that mag field was 0.294 Tesla in the affected runs


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2016

@slava77
Copy link
Contributor

slava77 commented Nov 4, 2016

+1

for #16462 4e1274f

  • assert is removed (commented out, just as in 81X); this affects only events that would otherwise crash
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 202e444 into cms-sw:CMSSW_8_0_X Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants