Pythia8 shower weights and labels saving

[pmandrik]

Pythia8 shower weights and labels saving (http://home.thep.lu.se/~torbjorn/pythia82html/Variations.html) in GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc

[cmsbuild]

A new Pull Request was created by @pmandrik for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[pmandrik]

please test

[perrozzi]

please test

[perrozzi]

@davidlange6 any issue with the bot not starting tests?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16276/console

[cmsbuild]

-1

Tested at: 986026a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16498/16276/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[perrozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16283/console

[cmsbuild]

-1

Tested at: 986026a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16498/16283/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[pmandrik]

Similar to
#16533
#16535
#16538

probably, not related to this PR

----- Begin Fatal Exception 10-Nov-2016 00:49:28 CET-----------------------
An exception of category 'DatabaseError ' occurred while
[0] Processing run: 160960
[1] Calling global beginRun for module LumiProducer/'lumiProducer'
Exception Message:
Can not get data (Additional Information: [frontier.c:1124]: No more proxies. Last error was: Request 83 on chan 2 failed at Thu Nov 10 00:49:28 2016: -8 [payload.c:101]: Server signalled payload error 1: LumiProd java.sql.SQLException: ORA-00942: table or view does not exist at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:456)) ( CORAL : "coral::FrontierAccess::Statement::execute" from "CORAL/RelationalPlugins/frontier" )
----- End Fatal Exception -------------------------------------------------

[perrozzi]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16297/console

[cmsbuild]

+1
Tested at: 986026a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16498/16297/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16498/16297/summary.html

[perrozzi]

@bendavid did you check this?

[bendavid]

Yes, I've looked at this and it should go into the release to facilitate testing. (It's disabled by default at the pythia config level, and can be enabled in the default pythia options fragment after the physics implications have been more thoroughly tested.)

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1