Hcal dump calibrations

[kpedro88]

HcalCalibrationsSet and HcalCalibrationWidthsSet are derived calibration objects which can contain some non-trivial information: pedestals and pedestal widths converted from adc to fC (using QIE coder), and "respcorrgain" (production of RespCorrs and Gains). This PR adds the ability to dump the relevant non-trivial information from these derived objects to text files, using the existing HCAL database tools.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibFormats/HcalObjects
CondTools/Hcal

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16232/console

[cmsbuild]

-1

Tested at: 981df4b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16499/16232/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/test/runTheWhiteRabbit.cpp 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/test/DummyBookFillDQMStoreMultiThread.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/test/DummyBookFillDQMStore.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/test/DummyHarvestingClient.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/EventFilter/CastorRawToDigi/plugins/CastorRawToDigi.cc:15:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/CalibCalorimetry/HcalAlgos/interface/HcalDbASCIIIO.h:126:49: error: 'HcalCalibrationWidthsSet' does not name a type
   bool dumpObject (std::ostream& fOutput, const HcalCalibrationWidthsSet& fObject);
                                                 ^
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/test/DummyTestReadDQMStore.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/src/DQMDcsInfo.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-11-07-1100/src/DQMServices/Components/src/DQMStoreStats.cc 


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #16499 was updated. @ghellwig, @cvuosalo, @cerminar, @cmsbuild, @franzoni, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

[kpedro88]

Build error was apparently due to an unnecessary include in CastorRawToDigi/plugins/CastorRawToDigi.cc which caused a BuildFile inconsistency when combined with the changes in this PR.

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16233/console

[cmsbuild]

+1
Tested at: 10869fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16499/16233/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16499/16233/summary.html

[mmusich]

+1

[kpedro88]

@ggovi @slava77 @cvuosalo please sign, has no effect on anything (only for HCAL development)

[cvuosalo]

+1

For #16499 10869fb

Enhancing HCAL development tools. The change in Reco code is extremely tiny. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-11-07-1100 show no significant differences, as expected.