Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SiStrip Report maps for each error flag separately #16521

Merged
merged 1 commit into from Nov 24, 2016

Conversation

lmoreels
Copy link
Contributor

@lmoreels lmoreels commented Nov 8, 2016

The current SiStrip Report Summary indicates the good detector fraction when taking into account a number error flags. If the good detector fraction is not 100%, it is not directly clear which error caused this. The additional Report maps take into account one error flag only, such that in case of problems, the origin can be quickly identified.

A PR for 81X is being prepared.

@boudoul
Copy link
Contributor

boudoul commented Nov 8, 2016

thanks @lmoreels , when you are ready with the 81X PR, please report the PR number here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

A new Pull Request was created by @lmoreels for CMSSW_8_0_X.

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @venturia this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@lmoreels
Copy link
Contributor Author

lmoreels commented Nov 9, 2016

PR for 81X: #16529

@idebruyn
Copy link
Contributor

@dmitrijus could you please start the tests? thanks.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16350/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@lmoreels
Copy link
Contributor Author

Is there a particular reason that this PR is not merged while the 81X one is? Please let me know if there is anything I need to do

@davidlange6
Copy link
Contributor

+1
its normal that newer releases get merged first - prs are run through all of the standard nightly tests (and ideally also relvals) before consideration for back porting.

@cmsbuild cmsbuild merged commit b980bee into cms-sw:CMSSW_8_0_X Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants