Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cond #1655

Merged
merged 2 commits into from Dec 6, 2013
Merged

Cond #1655

merged 2 commits into from Dec 6, 2013

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Dec 3, 2013

added an initialized of condition objects after they are read
tested

VinInn
VinInn reviewed Dec 3, 2013
View reviewed changes
CondCore/CalibPlugins/src/plugin.cc
@@ -16,11 +16,14 @@
#include "CondFormats/Common/interface/BaseKeyed.h"
#include "CondCore/IOVService/interface/KeyListProxy.h"

namespace {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2013

A new Pull Request was created by @VinInn for CMSSW_7_0_X.

Cond

It involves the following packages:

CondCore/ESSources
CondCore/CalibPlugins
CondFormats/Calibration

@apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@apfeiffer1
Copy link
Contributor

+1
once Jenkins gives the OK :)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1655/1564/summary.html

@Dr15Jones Dr15Jones mentioned this pull request Dec 3, 2013
Merged
@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 6, 2013
@nclopezo
Merge pull request #1655 from VinInn/Cond
0236a41 
Cond
@nclopezo nclopezo merged commit 0236a41 into cms-sw:CMSSW_7_0_X Dec 6, 2013
@VinInn VinInn deleted the Cond branch July 13, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VinInn @cmsbuild @apfeiffer1 @rcastello @nclopezo