Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make code pick up HI and PA EGM paths as well 80X #16552

Merged
merged 1 commit into from Nov 11, 2016

Conversation

afiqaize
Copy link
Contributor

80X sister PR of #16551.

Cheers,
Afiq

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @afiqaize (Afiq Anuar) for CMSSW_8_0_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mmusich
Copy link
Contributor

mmusich commented Nov 10, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16305/console

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@franzoni
Copy link

hello @afiqaize

the tests run by @cmsbuild prove your PR is technically sane,
but of course can't include running on pA data from this year.

Can you run on the collision run from last night :

https://cmswbm.web.cern.ch/cmswbm/cmsdb/servlet/LumiSections?RUN=285090

and check than indeed events pass into the egamma offline dqm ?

Thanks!

@afiqaize
Copy link
Contributor Author

Hi @franzoni

Can you please point me to instructions running the DQM starting from a RAW file? I tried with the available alcareco samples and while the histograms were properly created, they were not filled, perhaps because the events used to make them had no passing PAEG events.

Cheers,
Afiq

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 02ca417 into cms-sw:CMSSW_8_0_X Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants