Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bunchSpacingProducer in localreco* #16560

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 11, 2016

fixes a problem in hcalnzs setup in a workflow without miniAOD
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1490.html

[wait for jenkins before merging]

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor Author

slava77 commented Nov 11, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16314/console

@slava77
Copy link
Contributor Author

slava77 commented Nov 11, 2016

checked in 8_0_23_patch2 with recoinator RunPromptReco.py --scenario hcalnzsEra_Run2_2016 --reco --aod --dqmio ...: the buncSpacingProducer shows up in the produced config as expected.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Nov 11, 2016

+1

for #16560 39634ce

  • jenkins tests pass and comparisons show no differences
  • I also checked that our regular reco and reco+PAT workflows are not affected by looking at expanded configs in 8_0_23_patch2

davidlange6 added a commit that referenced this pull request Nov 11, 2016
…hSpacingToNZS

add bunchSpacingProducer in localreco* (fw port of #16560)
@davidlange6 davidlange6 merged commit 573de70 into cms-sw:CMSSW_8_0_X Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants