Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable HLT DQM, Validation and Harvesting sequences #16576

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Nov 14, 2016

this PR is needed to have the plots needed for the validation of the HLT menu in phase1 workflows
please, sign it as soon as possible

I tested w/ 10224.0 workflow, the corresponding DQM output is [1]

unfortunately, we realized this fix was not done yet only this afternoon :(
thanks !

[1]
/afs/cern.ch/work/t/tosi/public/STEAM/validation/2017_workflow/CMSSW_8_1_0_pre16/src/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

@mtosi
Copy link
Contributor Author

mtosi commented Nov 14, 2016

@hengne
Copy link
Contributor

hengne commented Nov 14, 2016

please test

@makortel
Copy link
Contributor

Please remove the lines instead of commenting them out.

Also note that there are still additional places where DQM/VALIDATION modules are turned off because HLT not being part of 2017 workflows in the past (all can be found with git grep phase1Pixel.*FIXME).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16334/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Configuration
HLTriggerOffline/Common

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@hengne
Copy link
Contributor

hengne commented Nov 14, 2016

@mtosi have you done all the cleanups?

@hengne
Copy link
Contributor

hengne commented Nov 14, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16339/console

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16576/16334/summary.html

Alternative comparison was/were failed for workflow(s):
25202.0

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@hengne
Copy link
Contributor

hengne commented Nov 15, 2016

+1

@hengne
Copy link
Contributor

hengne commented Nov 15, 2016

not sure if my signature works here... according to the labels, it is responsible by dqm group

@hengne
Copy link
Contributor

hengne commented Nov 15, 2016

otherwise computing/offline can sign it anyway, i guess.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b8e3d3 into cms-sw:CMSSW_8_1_X Nov 15, 2016
@mtosi
Copy link
Contributor Author

mtosi commented Nov 15, 2016

thanks !
mia

On Tue, Nov 15, 2016 at 3:18 PM, cmsbuild notifications@github.com wrote:

Merged #16576 #16576.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16576 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AEt581zNnaKFlOiAlfDc6lWzSLbPgi-Dks5q-b8fgaJpZM4Kxcrt
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants