added dark photon model to SimG4Core custom physics

[sushilchauhan]

Added dark photon interaction model to SimG4Core/CustomPhysics/ package. Its similar to Bethe-Heitler model but with a dark factor. Dark factor could be change from gen level config. pdg-id set to 1072000 for dark photon. Presented in simulation meeting on 15th November 2016.

[cmsbuild]

A new Pull Request was created by @sushilchauhan for CMSSW_8_1_X.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16361/console

[civanch]

@sushilchauhan , the code is OK for me but I would ask you to fix few things:

1. new model/process classes inherit from corresponding Geant4 classes but they are not produced by Geant4 Collaboration, so Geant4 disclaimers and comments should be removed.
2. you left some lines of code commented - implementation from the base class. It is fine when you develop but for CMSSW these commented lines should be removed.
3. in headers of new classes CMSSW convention is to use
   #ifndef SimG4Core_CustomPhysics_CMSDarkPairProduction_h

[cmsbuild]

+1
Tested at: 7141cab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16580/16361/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16580/16361/summary.html

[sushilchauhan]

@civanch I will update the branch with your suggestion sometime soon today. Thanks.

[civanch]

@sushilchauhan , please take into account, that 9_0_X branch is in a process of creation. All new PRs are cloned to this branch. Try to commit to 8_1_X and later we will see how to add this commit to 9_0_X (likely will not be peaked up automatically). Also you may do 7_1_X PR - it is our final target. Better if you do 7_1_X from scratch on top of most recent 7_1_X IB, so would be easy to make minor modifications if would needed.

[cmsbuild]

Pull request #16580 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

[sushilchauhan]

@civanch, I just updated the branch used for PR for 81X. Please have a look if its fine. We will do a separate PR for 7_1_X soon as suggested.

[civanch]

@sushilchauhan , there is a technical problem in validation (not only this PR). Some time will be needed to recover the system. Because you have implemented all comments it is possible to make 7_1_X PR.

[sushilchauhan]

@civanch , Thanks Vladimir! We will submit that soon today.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16500/console

[cmsbuild]

+1
Tested at: 7187305
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16580/16500/summary.html

[cmsbuild]

Comparison job queued.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16580/16500/summary.html

Alternative comparison was/were failed for workflow(s):
1330.0

[davidlange6]

+1