Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-ft11 Update README file in Configuration/Geometry and add required files for FastTime Reco Geometry #16590

Merged
merged 1 commit into from Nov 16, 2016

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 16, 2016

Updating the README file; include fast time RECO geometry in I2; making room for Geometry tester for FastTimer. This is an addition after PR# 16562

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Nov 16, 2016
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16360/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Geometry/HGCalGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bsunanda
Copy link
Contributor Author

Creation of a geometry with I2 can be done with this only after PR 16562 was integrated

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented Nov 16, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

hi @bsunanda -please update the title to be something more descriptive for the release notes. Thanks!

@bsunanda bsunanda changed the title bsunanda:Phase2-ft11 addition after PR 16562 bsunanda:Phase2-ft11 Update README file in Configuration/Geometry and add required files for FastTime Reco Geometry Nov 16, 2016
@bsunanda
Copy link
Contributor Author

@davidlange6 Done that

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 83e409f into cms-sw:CMSSW_8_1_X Nov 16, 2016
"reco" :[
'from Geometry.CaloEventSetup.FastTimeTopology_cfi import *',
'from Geometry.HGCalGeometry.FastTimeGeometryESProducer_cfi import *',
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda you did not actually regenerate the geometry cffs after this change. Was that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants