New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Phase2-ft11 Update README file in Configuration/Geometry and add required files for FastTime Reco Geometry #16590
Conversation
@cmsbuild Please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Creation of a geometry with I2 can be done with this only after PR 16562 was integrated |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
hi @bsunanda -please update the title to be something more descriptive for the release notes. Thanks! |
@davidlange6 Done that |
+1 |
"reco" :[ | ||
'from Geometry.CaloEventSetup.FastTimeTopology_cfi import *', | ||
'from Geometry.HGCalGeometry.FastTimeGeometryESProducer_cfi import *', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda you did not actually regenerate the geometry cffs after this change. Was that intentional?
Updating the README file; include fast time RECO geometry in I2; making room for Geometry tester for FastTimer. This is an addition after PR# 16562