Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Phase I - CA - improving fake rejection at high pt #16612

Merged

Conversation

cmsbuild
Copy link
Contributor

In the Cellular Automaton, we now require that, if two doublets are aligned in the xy-plane, they also have to be aligned with the beamspot ± (region radius + tolerance).
This has the effect of reducing the fake rate for pt > 10GeV/c, for quadruplets and especially for triplets.

@VinInn @rovere @makortel
Automatically ported from CMSSW_8_1_X #16491 (original by @felicepantaleo).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

RecoPixelVertexing/PixelTriplets

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @dgulhan, @rovere, @VinInn this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@VinInn
Copy link
Contributor

VinInn commented Nov 16, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16363/console

@slava77
Copy link
Contributor

slava77 commented Nov 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16402/console

@slava77
Copy link
Contributor

slava77 commented Nov 17, 2016

@cmsbuild please test
maybe this time tests run

@smuzaffar do we still have a problem running 90X tests?

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16445/console

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 17, 2016

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16612/16445/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
  • 21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5

@cmsbuild
Copy link
Contributor Author

Pull request #16612 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16536/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

@slava77
Copy link
Contributor

slava77 commented Nov 23, 2016

+1

for #16612 c9758c1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6fdce71 into cms-sw:CMSSW_9_0_X Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants