Don't store bunchspace as it may be updated #1662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request 1615 (already merged) fixed a problem with multiple time shifting of the same hits in the mixing module.
However, the Adjuster class that implemented this stored the bunchspace. The Mixing Module allows the bunch space to be updated on run or lumi boundaries. If this happened, the adjuster would still use the original value.
This simple pull request fixes this by passing in the bunch space as an argument, rather than storing it as a member of the Adjuster class.