Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store bunchspace as it may be updated #1662

Merged
merged 1 commit into from Dec 5, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 4, 2013

Pull request 1615 (already merged) fixed a problem with multiple time shifting of the same hits in the mixing module.
However, the Adjuster class that implemented this stored the bunchspace. The Mixing Module allows the bunch space to be updated on run or lumi boundaries. If this happened, the adjuster would still use the original value.

This simple pull request fixes this by passing in the bunch space as an argument, rather than storing it as a member of the Adjuster class.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Don't store bunchspace as it may be updated

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @giamman can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

@mdhildreth
Copy link
Contributor

+1

On Dec 4, 2013, at 5:12 AM, cmsbuild notifications@github.com wrote:

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1662/1582/summary.html


Reply to this email directly or view it on GitHub.


Mike Hildreth e-mail: mikeh@undhep.hep.nd.edu
Department of Physics mikeh@fnal.gov
225 Nieuwland Sciences Hall telephone: 574-631-6458 (office)
University of Notre Dame 574-631-5952 (FAX)
Notre Dame, IN 46556 http://www.hep.nd.edu/MikeHildreth

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 5, 2013
Don't store bunchspace as it may be updated
@nclopezo nclopezo merged commit 33cea24 into cms-sw:CMSSW_7_0_X Dec 5, 2013
@wmtan wmtan deleted the ProtectAgainstBunchSpaceUpdate branch December 9, 2013 22:18
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data-RecoEgamma ElectronIdentification and PhotonIdentification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants