Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a boost on particles in MCParticlePairFilter #16621

Merged
merged 1 commit into from Jan 17, 2017

Conversation

cmsbuild
Copy link
Contributor

This change is needed to be able to apply generator-level cuts on momenta in the laboratory frame, instead of the centre of mass frame, in the case of boosted MC production (for proton-lead). Note that this is a different strategy than what was used for 5TeV pPb production (for Run1, in 53X), when a customisation swapping the boost and the filter was used instead (https://github.com/cms-sw/cmssw/blob/CMSSW_5_3_X/GeneratorInterface/HiGenCommon/python/customiseSwapVtxSmearAndProdFilter_cfi.py).
@kurtejung and @mandrenguyen are aware of this pull request.
Let me know if you have any comment on the implementation.
Automatically ported from CMSSW_8_1_X #16425 (original by @echapon).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

GeneratorInterface/GenFilters

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16371/console

@perrozzi
Copy link
Contributor

please test

1 similar comment
@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jan 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17310/console Started: 2017/01/17 07:31

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1
impressive to find a 4-vector class without a boost method - maybe a better one should be used in this class in the future?

@cmsbuild cmsbuild merged commit bdb5261 into cms-sw:CMSSW_9_0_X Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants