Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HCAL scale monitoring, create PFCandidate Analyzer #16650

Merged
merged 5 commits into from Nov 29, 2016

Conversation

cmsbuild
Copy link
Contributor

create PFCandidateAnalyzer, move existing PFCandidate Monitoring histograms from METAnalyzer into newly created module. Add HCAL scale monitoring based on isolated charged hadron candidates comparing HCAL Cluster Energies and Track momentum. Reduce number of bins in phi for PFCandidate eta-phi maps.

Automatically ported from CMSSW_8_1_X #13587 (original by @JetMETdqmval).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_9_0_X.

It involves the following packages:

DQMOffline/JetMET

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@webermat
Copy link
Contributor

I apologize, the message for the previous PR must have gotten lost among the emails of my new job. The requested change from fabs to abs, as well as the rebase are in.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Nov 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16648/console

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16650/16648/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3d0e819 into cms-sw:CMSSW_9_0_X Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants