Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GLOBAL_TAG table names in sqlite files #16655

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Nov 16, 2016

Workaround for the support of GTs in sqlite files.
The prefix 'GLOBAL_' is a keyword for sqlalchemy, which makes the tables starting with 'GLOBAL_' unreadable in sqlite.
The tables are created with lower case names to make the model happy, and then re-named.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_9_0_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ggovi
Copy link
Contributor Author

ggovi commented Nov 16, 2016

please test

@ggovi
Copy link
Contributor Author

ggovi commented Nov 17, 2016

@smuzaffar
anything hanging here?

@smuzaffar
Copy link
Contributor

CMSSW_9_0_X IB was not available went the tests were requested. As IB is available now, so I have retsrated the test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor Author

ggovi commented Nov 22, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 29b3e45 into cms-sw:CMSSW_9_0_X Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants