Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emdqm standalone #1667

Merged
merged 12 commits into from Dec 6, 2013
Merged

Emdqm standalone #1667

merged 12 commits into from Dec 6, 2013

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Dec 4, 2013

Migration from getByLabel to getByToken for HLTriggerOffline/Egamma package.

Code for isolation histograms could not easily be migrated and is now commented out. The histograms there were actually never filled before anyway because the data necessary was not stored in the HLTDEBUG tier.
In central DQM the iso plots are also switched off in the configuration.

EmDQMFeeder was erased because its functionality is now included in EmDQM.
Some old python config files for obsolete triggers were erased as well.

I have Tested the changes with 7_0_0_pre8 relval samples (ZEE, WE, PhotonJetsPt10, H130GGgluonfusion) and observed no changes wrt. the previous version.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2013

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_7_0_X.

Emdqm standalone

It involves the following packages:

HLTriggerOffline/Egamma

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

nclopezo commented Dec 5, 2013

@thomreis

Hi Thomas,

This pull request is unmergeable, could you please rebase it?

…dqm_standalone

Conflicts:
	HLTriggerOffline/Egamma/src/EmDQMFeeder.cc

I have erased it because it was not used anymore but someone else
changed it in the meantime.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

Pull request #1667 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

Pull request #1667 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

-1
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 05-Dec-2013 13:12:36 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling endRun for unscheduled module EmDQM/'emdqm'
Exception Message:
A std::exception was thrown.
vector::_M_range_check
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 05-Dec-2013 13:14:02 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling endRun for unscheduled module EmDQM/'emdqm'
Exception Message:
A std::exception was thrown.
vector::_M_range_check
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 05-Dec-2013 13:15:37 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling endRun for unscheduled module EmDQM/'emdqm'
Exception Message:
A std::exception was thrown.
vector::_M_range_check
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 05-Dec-2013 13:24:04 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 1
   [1] Calling endRun for unscheduled module EmDQM/'emdqm'
Exception Message:
A std::exception was thrown.
vector::_M_range_check
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1667/1596/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

Pull request #1667 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

@deguio
Copy link
Contributor

deguio commented Dec 6, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 6, 2013
@nclopezo nclopezo merged commit a629be6 into cms-sw:CMSSW_7_0_X Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants