New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch phase1 tracking to generic pixel CPE #16703
Switch phase1 tracking to generic pixel CPE #16703
Conversation
Done because with the final pixel geometry, template CPE has a (small) bias. Switching back to generic CPE until we have a fix. This commit essentially reverts ef463c1.
@cmsbuild, please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X. It involves the following packages: RecoMuon/Configuration @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
Comparison is ready Alternative comparison was/were failed for workflow(s): |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This commit reverts commit 4d99df7 of PR cms-sw#16703.
Following the pixel offline presentation on last Friday's TRK DPG-POG meeting https://indico.cern.ch/event/536891/contributions/2376928/attachments/1374299/2086018/2016_11_18_PixelOfflineMeeting_PhaseIOfflinePlansUpdate.pdf showing a bias in the template CPE for the (final) phase1 pixel, we decided to switch the phase1 tracking (back) to generic CPE until the bias is fixed (in a way or another). This PR effectively reverts #14159.
Here are MTV plots for 1000 ttbar+35 PU events in 810pre16
https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre16_phase1_genericCPE
There are tiny effects in efficiencies, fake rates etc. Most visible effects are in
Tested in 8_1_0_pre16, expecting changes in 2017 workflows.
@rovere @VinInn @veszpv @boudoul