Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch phase1 tracking to generic pixel CPE #16703

Merged
merged 1 commit into from Nov 24, 2016

Conversation

makortel
Copy link
Contributor

Following the pixel offline presentation on last Friday's TRK DPG-POG meeting https://indico.cern.ch/event/536891/contributions/2376928/attachments/1374299/2086018/2016_11_18_PixelOfflineMeeting_PhaseIOfflinePlansUpdate.pdf showing a bias in the template CPE for the (final) phase1 pixel, we decided to switch the phase1 tracking (back) to generic CPE until the bias is fixed (in a way or another). This PR effectively reverts #14159.

Here are MTV plots for 1000 ttbar+35 PU events in 810pre16
https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre16_phase1_genericCPE
There are tiny effects in efficiencies, fake rates etc. Most visible effects are in

Tested in 8_1_0_pre16, expecting changes in 2017 workflows.

@rovere @VinInn @veszpv @boudoul

Done because with the final pixel geometry, template CPE has a (small)
bias. Switching back to generic CPE until we have a fix.

This commit essentially reverts ef463c1.
@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16505/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

RecoMuon/Configuration
RecoMuon/GlobalTrackingTools
RecoMuon/MuonIdentification
RecoMuon/TrackingTools
RecoParticleFlow/PFTracking
RecoTracker/FinalTrackSelectors
RecoTracker/SpecialSeedGenerators
RecoTracker/TrackProducer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @abbiendi, @dgulhan, @mmarionncern, @battibass, @jhgoh, @lgray, @HuguesBrun, @trocino, @rociovilar, @GiacomoSguazzoni, @rafaellopesdesa, @rovere, @VinInn, @bellan, @mschrode, @amagitte, @calderona, @cbernet, @gpetruc, @bachtis this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16703/16505/summary.html

Alternative comparison was/were failed for workflow(s):
25.0

@slava77
Copy link
Contributor

slava77 commented Nov 24, 2016

+1

for #16703 4d99df7

  • changes are as described, the same as proposed in 81X
  • jenkins tests pass and comparisons show differences only in 2017 workflows

see #16740 for additional pre-signoff plots

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 570d743 into cms-sw:CMSSW_9_0_X Nov 24, 2016
makortel added a commit to makortel/cmssw that referenced this pull request Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants