[90X] Geometry independent SiPixelAli PCL

[ghellwig]

• replace hard-coded labels with automatically deduced labels, based on the used tracker geometry
• move MillePede-related part from PCLTrackerAlProducer to MillePedeAlignmentAlgorithm
  --> step towards unification of PCLTrackerAlProducer and AlignmentProducer

[cmsbuild]

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_9_0_X.

It involves the following packages:

Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16578/console

[cmsbuild]

+1
Tested at: 2e1dfe8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16749/16578/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
36cb014
9c64be5
7641e5f
b8eb26b
1e597a6
63a8566
8874833
ace3cb4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16749/16578/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16749/16578/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16749/16578/summary.html

[ghellwig]

hold

[cmsbuild]

Pull request has been put on hold by @ghellwig
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request #16749 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16771/console

[ghellwig]

unhold

[cmsbuild]

+1
Tested at: 76d9a7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16749/16771/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16749/16771/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

[mmusich]

@tlampen @mschrode @usarica - as verbally discussed yesterday during the alignment meeting - we'll wait for explicit sign-off on the HipPy side, since the algorithm is not run in the PR tests.

[ghellwig]

@usarica do you have any objections regarding this PR? Further development depends on its integration.

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1