Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make_shared in visualization #16768

Merged
merged 1 commit into from Nov 27, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 26, 2016

"auto thePtr = std::make_shared<MyClass>(...)" is preferred to "shared_ptr thePtr(new MyClass(...))" because it saves a memory allocation. It allocates the shared_ptr and the pointee in the same allocation.
This PR changes the places in visualization that did it the suboptimal way. To do this, it was necessary to replace the use of boost::shared_ptr with std::shared_ptr, which was done throughout visualization.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_9_0_X.

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Nov 26, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16612/console

@cmsbuild
Copy link
Contributor

Pull request #16768 was updated. @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please check and sign again.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 26, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16613/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit e46d222 into cms-sw:CMSSW_9_0_X Nov 27, 2016
@wmtan wmtan deleted the UseMakeSharedInVisualization branch November 28, 2016 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants