New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use make_shared in visualization #16768
Use make_shared in visualization #16768
Conversation
A new Pull Request was created by @wmtan for CMSSW_9_0_X. It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
105b0bb
to
4c89625
Compare
Pull request #16768 was updated. @cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
"auto thePtr = std::make_shared<MyClass>(...)" is preferred to "shared_ptr thePtr(new MyClass(...))" because it saves a memory allocation. It allocates the shared_ptr and the pointee in the same allocation.
This PR changes the places in visualization that did it the suboptimal way. To do this, it was necessary to replace the use of boost::shared_ptr with std::shared_ptr, which was done throughout visualization.