Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal validation new histograms #16773

Merged
merged 4 commits into from Dec 1, 2016

Conversation

kencall
Copy link
Contributor

@kencall kencall commented Nov 28, 2016

Back port of PR#16691

It makes additions to DQMOffline/Hcal/HcalRecHitsAnalyzer

The following histograms are added for HB and HE:

Emean_vs_ieta (M0)
Emean_vs_ieta (M3)

RecHit Energy (M0)
RecHit Energy (M3)

RecHit Energy (M2 vs. M0)
RecHit Energy (M3 vs. M0)
RecHit Energy (M3 vs. M2)

Log10(M2 Chi2) spectra and profile vs energy.

Hcal RecHits:
Add rechit energy spectra and emean vs ieta for M0 and M3 in HB and HE
Add log(M2 Chi2) spectra for HB and HE
Add M2 vs M0, M3 vs M0, and M3 v M2, rechit energy comparison for HB and HE

Hcal Simhits:
Add energy weighted HF depths Histogram. (Useful for checking the p.e. split in the dual anode readout)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kencall for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Hcal
Validation/HcalHits

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16637/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@dmitrijus
Copy link
Contributor

Needs a 90x port.

@kpedro88
Copy link
Contributor

Backport of #16691

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6eb081d into cms-sw:CMSSW_8_1_X Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants