Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consume for ecal hitsand trigger prim #1679

Merged

Conversation

borrello
Copy link
Contributor

@borrello borrello commented Dec 5, 2013

Fix fir consumes for Validation/EcalRecHits and Validation/EcalTriggerPrimitives

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

A new Pull Request was created by @borrello for CMSSW_7_0_X.

Fix consume for ecal hitsand trigger prim

It involves the following packages:

Validation/EcalTriggerPrimitives
Validation/EcalRecHits

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

@mulhearn
Copy link
Contributor

mulhearn commented Dec 5, 2013

+1

1 similar comment
@deguio
Copy link
Contributor

deguio commented Dec 6, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 6, 2013
…erPrim

Fix consume for ecal hitsand trigger prim
@nclopezo nclopezo merged commit 10d55e9 into cms-sw:CMSSW_7_0_X Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants