Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[81X] Fix misalignment tool for phase-1 (and phase-2) configurations (backport of #16860). #16861

Merged

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Dec 5, 2016

backport of #16860

Fixes behaviour if alignable names contain numbers.

@ghellwig
Copy link
Author

ghellwig commented Dec 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16773/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignment

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

Comparison job queued.

@mmusich
Copy link
Contributor

mmusich commented Dec 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2016

@franzoni
Copy link

franzoni commented Dec 6, 2016

type bugfix

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b5f8ae into cms-sw:CMSSW_8_1_X Dec 9, 2016
@ghellwig ghellwig deleted the fix-misalignment-tool-phase-1_81X branch December 21, 2016 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants