Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag function declarations in extern "C" blocks ending with _ #1687

Merged
merged 1 commit into from Dec 6, 2013
Merged

flag function declarations in extern "C" blocks ending with _ #1687

merged 1 commit into from Dec 6, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 5, 2013

Since these are most likely fortran functions that access COMMONBLOCK variables they should be flagged and then checked if they appear in the call stack of top level functions.

…t likely fortran functions that access COMMONBLOCK variables
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

flag function declarations in extern "C" blocks ending with _

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 6, 2013
flag function declarations in extern "C" blocks ending with _
@nclopezo nclopezo merged commit 38b550a into cms-sw:CMSSW_7_0_X Dec 6, 2013
@gartung gartung deleted the clang-flag-fortran-function branch December 6, 2013 15:32
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
cleanup fwlite dependency: removed roofit-toolfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants