New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimHit vs. RecHit Validation (Backport from 90X, PR#16734) #16874
Conversation
…lRecHits/HcalRecHitsValidation in PR # Support for testNumbering in the SimHit collection is added.
…alRecHits/interface/HcalRecHitsValidation.h fixed testNumbering customization in Validation/HcalRecHits/python/HcalRecHitParam_cfi.py standardized profile booking to remove unused y-axis binning
…tly being validated, if such a subdetector has been specified
A new Pull Request was created by @kencall for CMSSW_8_1_X. It involves the following packages: Validation/HcalRecHits @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Comparison job queued. |
@davidlange6 this needs to be merged before the 2017 HE changes can be backported to 81X (TestNumbering will be used for all MC 2017 onward) |
@kencall since we'll no longer use 81X, this PR can be closed. |
This is a backport from 90X to 81X. (PR #16734)
Restores SimHit vs. RecHit comparisons removed from Validation/HcalRecHits/HcalRecHitsValidation. It adds support for testNumber in SimHit collection which is currently being used in 2023 workflows.