New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put in failsafe to not run PreMixing and HIP simulation simultaneously #16906
Conversation
A new Pull Request was created by @boudoul (boudoul) for CMSSW_9_0_X. It involves the following packages: SimTracker/SiStripDigitizer @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
In validation of this PR (as in some recent) SiStrip has huge number of failing comparisons. Obviously this PR cannot be responsible. |
+1 |
This is preventing to run premixing when switching on the HIP simulation
Forward port of the last commit from @mdhildreth in the 80X PR #15458 , keeping all release cycles in synch