Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put in failsafe to not run PreMixing and HIP simulation simultaneously #16906

Merged
merged 1 commit into from Dec 8, 2016

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Dec 7, 2016

This is preventing to run premixing when switching on the HIP simulation

Forward port of the last commit from @mdhildreth in the 80X PR #15458 , keeping all release cycles in synch

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

A new Pull Request was created by @boudoul (boudoul) for CMSSW_9_0_X.

It involves the following packages:

SimTracker/SiStripDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @jlagram, @rovere, @VinInn, @cnuttens, @prolay, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Dec 8, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16858/console Started: 2016/12/08 11:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16906/16858/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@civanch
Copy link
Contributor

civanch commented Dec 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@civanch
Copy link
Contributor

civanch commented Dec 8, 2016

In validation of this PR (as in some recent) SiStrip has huge number of failing comparisons. Obviously this PR cannot be responsible.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 462afba into cms-sw:CMSSW_9_0_X Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants