Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use obsolete signals #1691

Merged
merged 1 commit into from Dec 8, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 5, 2013

In branch CMSSW_7_0_THREADED_X, the ProfilerService tests in PerfTools/Callgrind were failing because the ProfilerService used obsolete signals.
This pull request replaces the use of each obsolete signal with the use of its replacement.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_THREADED_X.

Don't use obsolete signals

It involves the following packages:

PerfTools/Callgrind

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Dec 8, 2013
Multithreading fixes -- Don't use obsolete signals
@ktf ktf merged commit feb4339 into cms-sw:CMSSW_7_0_THREADED_X Dec 8, 2013
@wmtan wmtan deleted the DoNotUseObsoleteSignals branch December 9, 2013 22:17
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update RecoEgamma/ElectronIdentification data to V01-00-04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants