Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CondTool/DT fix clang warning -Wabsolute-value #16916

Merged
merged 1 commit into from Dec 21, 2016
Merged

CondTool/DT fix clang warning -Wabsolute-value #16916

merged 1 commit into from Dec 21, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 8, 2016

Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/7a46df93c511389b47098a1f5c9e31bc/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-08-1100/src/CondTools/DT/test/validate/DTDeadFlagValidateDBRead.cc
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/llvm/4.0.0/bin/clang++ -c -DGNU_GCC -D_GNU_SOURCE -DCMSSW_GIT_HASH="CMSSW_9_0_CLANG_X_2016-12-08-1100" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_9_0_CLANG_X_2016-12-08-1100" -DTBB_USE_GLIBCXX_VERSION=50300 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/7a46df93c511389b47098a1f5c9e31bc/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-08-1100/src -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/cms/coral/CORAL_2_3_21-ghmdbj/include/LCG -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/lcg/root/6.06.08-ogepgl/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/boost/1.57.0-oenich/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/pcre/8.37/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/bz2lib/1.0.6/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/clhep/2.3.4.2/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/libuuid/2.22.2/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/openssl/1.0.2d/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/python/2.7.11-oenich/include/python2.7 -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/tbb/2017_20161004oss/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/xerces-c/3.1.3/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/zlib/1.2.8/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/md5/1.0.0/include -I/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/slc6_amd64_gcc530/external/tinyxml/2.5.3-oenich/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++14 -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Wa,--compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=uninitialized -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -DBOOST_DISABLE_ASSERTS -Wno-error=unused-variable -Wno-error=unused-variable -fPIC -MMD -MF tmp/slc6_amd64_gcc530/src/CondTools/DT/test/CondToolsDTValidate/validate/DTDeadFlagValidateDBRead.d /build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/7a46df93c511389b47098a1f5c9e31bc/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-08-1100/src/CondTools/DT/test/validate/DTDeadFlagValidateDBRead.cc -o tmp/slc6_amd64_gcc530/src/CondTools/DT/test/CondToolsDTValidate/validate/DTDeadFlagValidateDBRead.o
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/7a46df93c511389b47098a1f5c9e31bc/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-08-1100/src/CondTools/DT/test/validate/DTTPGParametersValidateHandler.cc:106:16: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value]
if ( ( fabs( ckclock - nClock ) > 0.0001 ) ||
^
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/7a46df93c511389b47098a1f5c9e31bc/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-08-1100/src/CondTools/DT/test/validate/DTTPGParametersValidateHandler.cc:106:16: note: use function 'std::abs' instead
if ( ( fabs( ckclock - nClock ) > 0.0001 ) ||
^~~~
std::abs

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 8, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

CondTools/DT

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@gartung
Copy link
Member Author

gartung commented Dec 8, 2016

@Dr15Jones

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16866/console Started: 2016/12/08 22:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

+1
Tested at: 7589283
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16916/16866/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
21e8c84
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16916/16866/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16916/16866/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16916/16866/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

davidlange6
davidlange6 reviewed Dec 9, 2016
View reviewed changes
CondTools/DT/test/validate/DTTPGParametersValidateDBRead.cc
@@ -93,8 +93,8 @@ void DTTPGParametersValidateDBRead::analyze( const edm::Event& e,
sta,
sec,
nClock, tPhase, DTTimeUnits::counts );
if ( ( fabs( ckclock - nClock ) > 0.0001 ) ||
( fabs( ckphase - tPhase ) > 0.0001 ) )
if ( ( std::abs( ckclock - nClock ) > 0.0001 ) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it should just be if ckclock!=nClock
-as changed, I think we will just change one warning for another

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a test class. This removes the warning.

@davidlange6 davidlange6 merged commit 4a85127 into cms-sw:CMSSW_9_0_X Dec 21, 2016
@gartung gartung deleted the CondTool-DT-fix-clang-warning-fabs-int branch December 21, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-available db-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gartung @cmsbuild @Dr15Jones @davidlange6