Calibration/EcalCalibAlgos fix clang warning about abs #16918
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X. It involves the following packages: Calibration/EcalCalibAlgos @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
before the fix of parenthesis here: where were the consequences on EE- Thanks, g. |
|
dear giovanni,
this module is used anymore.
The only one that can still be using it is "Zee iterative IC" that is being re-developed now (this method was never used so far but developed before 2010).
So no impact on old and/or new results.
…--
Shervin
________________________________________
Da: Giovanni Franzoni [notifications@github.com]
Inviato: venerd� 9 dicembre 2016 10.29
A: cms-sw/cmssw
Cc: Shervin Nourbakhsh; Mention
Oggetto: Re: [cms-sw/cmssw] Calibration/EcalCalibAlgos fix clang warning about abs (#16918)
@gartung<https://github.com/gartung> @shervin86<https://github.com/shervin86>
before the fix of parenthesis here:
https://github.com/gartung/cmssw/blob/7208c20098d71cc88a04197459b116d75de5b827/Calibration/EcalCalibAlgos/src/InvRingCalib.cc#L318
where were the consequences on EE-
of retrieving a Max DetIt from the barrel collection ?
What role does InvRingCalib play in the ECAL calibration workflows ?
Thanks, g.
�
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#16918 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEXCJWOiUOuChbgV-Z4IV20IpTDzsvbqks5rGR-JgaJpZM4LITos>.
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
+1 |
warnings.txt:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/Calibration/EcalCalibAlgos/src/EcalEleCalibLooper.cc:260:10: warning: taking the absolute value of unsigned type 'bool' has no effect [-Wabsolute-value]
warnings.txt:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/Calibration/EcalCalibAlgos/src/EcalEleCalibLooper.cc:260:10: note: remove the call to 'fabs' since unsigned values cannot be negative
warnings.txt:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/Calibration/EcalCalibAlgos/src/InvRingCalib.cc:318:11: warning: taking the absolute value of unsigned type 'bool' has no effect [-Wabsolute-value]
warnings.txt:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/Calibration/EcalCalibAlgos/src/InvRingCalib.cc:318:11: note: remove the call to 'fabs' since unsigned values cannot be negative
warnings.txt.unique:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/Calibration/EcalCalibAlgos/src/EcalEleCalibLooper.cc:260:10: warning: taking the absolute value of unsigned type 'bool' has no effect [-Wabsolute-value]
warnings.txt.unique:/scratch/gartung/CMSSW_9_0_CLANG_X_2016-12-06-1100/src/Calibration/EcalCalibAlgos/src/InvRingCalib.cc:318:11: warning: taking the absolute value of unsigned type 'bool' has no effect [-Wabsolute-value]