Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop gcc 6.2 compiler warnings in PF data products #16949

Merged
merged 1 commit into from Dec 11, 2016

Conversation

Dr15Jones
Copy link
Contributor

The gcc 6.2 compiler was complaining about operator<< for various
ParticleFlow data products not being in the proper namespace. As
part of the cleanup of the warnings all the operator<< are no longer
friends of the classes (since they can all use public methods).

The gcc 6.2 compiler was complaining about operator<< for various
ParticleFlow data products not being in the proper namespace. As
part of the cleanup of the warnings all the operator<< are no longer
friends of the classes (since they can all use public methods).
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2016

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X.

It involves the following packages:

DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@lgray, @rafaellopesdesa, @bachtis, @cbernet this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16921/console Started: 2016/12/09 20:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #16949 698077f

Fixing gcc 6.2 compiler warnings in ParticleFlow code. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_9_0_X_2016-12-09-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8aef8d9 into cms-sw:CMSSW_9_0_X Dec 11, 2016
@Dr15Jones Dr15Jones deleted the fixWarningsPFDataProducts branch December 13, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants