New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop gcc 6.2 compiler warnings in PF data products #16949
Stop gcc 6.2 compiler warnings in PF data products #16949
Conversation
The gcc 6.2 compiler was complaining about operator<< for various ParticleFlow data products not being in the proper namespace. As part of the cleanup of the warnings all the operator<< are no longer friends of the classes (since they can all use public methods).
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X. It involves the following packages: DataFormats/ParticleFlowCandidate @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
The gcc 6.2 compiler was complaining about operator<< for various
ParticleFlow data products not being in the proper namespace. As
part of the cleanup of the warnings all the operator<< are no longer
friends of the classes (since they can all use public methods).