Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gcc620 warning in OscarProducer #16963

Merged
merged 1 commit into from Dec 11, 2016

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Dec 10, 2016

The same method is removed from both producers, because it is not used and will be not used.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_9_0_X.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch civanch changed the title Fixed gcc620 warning Fixed gcc620 warning in OscarProducer Dec 10, 2016
@civanch
Copy link
Contributor Author

civanch commented Dec 10, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16945/console Started: 2016/12/10 19:00

@civanch
Copy link
Contributor Author

civanch commented Dec 10, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5478e54 into cms-sw:CMSSW_9_0_X Dec 11, 2016
@Dr15Jones
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants