Making Phase2 T2 (and 2023D2) more realistic [using Pixel phase2 rather than a la Phase1] - Renamed as T4 and 2023D10 Resp. #16971
Conversation
|
A new Pull Request was created by @boudoul (boudoul) for CMSSW_9_0_X. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild, please test with cms-sw/cmsdist#2732 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
@slava77 should I produce the comparison for D2 before/after the PR? |
|
On 12/12/16 5:58 AM, ebrondol wrote:
@slava77 <https://github.com/slava77> should I produce the comparison
for D2 before/after the PR?
I think it would be pretty useful for the record.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16971 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbktj4S8O4mzi9GSSM4EKy7GAn3O5ks5rHVMLgaJpZM4LKCXb>.
|
cmsbuild
added
comparison-available
and removed
comparison-pending
comparison-available
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
Comparison job queued. |
|
+1 |
|
+1
|
|
@boudoul @atricomi Are we supposed to update: |
|
In principle yes, we should remove the option with the old pixel geometries if we wish to be consistent with the new scenarios.
… Il giorno 19 dic 2016, alle ore 15:20, ebrondol ***@***.***> ha scritto:
@boudoul <https://github.com/boudoul> @Tricomi Are we supposed to update:
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/Geometry/TrackerNumberingBuilder/README.md <https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/Geometry/TrackerNumberingBuilder/README.md>
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#16971 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE88kZ86MFp6kMMPL-utI_7fYlu9Mbxlks5rJpLEgaJpZM4LKCXb>.
|
|
@atricomi |
|
@atricomi @venturia You can find my modifications on the two files discussed in this branch. I think the pixel part is still not up-to-date. |
Greetings, this is to finally get rid of the 'pixel a la phase1' which was only used in 2023D2 - Instead we are using the phase2 pixel together with the already existing Flat Outer Tracker (that we would like to keep)- Work done by @ghugo83
@smuzaffar This PR should be tested with :
cms-data/SLHCUpgradeSimulations-Geometry#4
Tested with the Workflow 20400
In case there is an interference with #16965 (or any further PRs..) , I will update accordingly
Adding usual watchers : @delaere , @atricomi , @rovere , @VinInn @makortel @ebrondol @venturia, @ghugo83