Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the online DQM fileinputsource more intelligent #16973

Merged
merged 2 commits into from Jan 10, 2017

Conversation

schneiml
Copy link
Contributor

This allows reprocessing StreamExpress runs, as it was needed to analyse some Pilot Blade timing scan data after the online shutdown. It could also be useful in the future and for general Phase1 online DQM development.

One dataset (as returned from DAS) can have many runs, so we allow selecting a specific run. The
dataset always has all events and will be fully processed, which can be too much for the online DQM, therefore we allow selecting a subset of LS (like in the lookarea).

Remaining problem: The input files as reported from DAS appear in random order, so it can happen that many files have to be opened to find a small LS range, and the data will appear randomly in the DQM live view.

This configuration includes the dataset with the last 2016 pPb runs (again, as they were interesting for the Pilot Blade team and culd not be analysed using the online system). It is by default enabled in the pixel and pixel_up online clients after #16875 .

To allow reprocessing StreamExpress runs. One dataset (as returned from
DAS) can have many runs, so we allow selecting a specific run. The
dataset always has all events and will be fully processed, which can be
too much for the online DQM, therefore we allow selecting a subset of LS.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_9_0_X.

It involves the following packages:

DQM/Integration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16967/console Started: 2016/12/12 15:59

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@dmitrijus
Copy link
Contributor

Regardless dataset_cfi.py, would it not make sense to query these from DAS directly?

@schneiml
Copy link
Contributor Author

Yes it would, but I'd have to figure out how to do this. Any hints where to steal the relevant code?

@dmitrijus
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@schneiml
Copy link
Contributor Author

Progress note here: I found the snippet that queries DAS for the runTheMatrix sequences and it looks like that can be used here. Now I just have to come up with a working DAS query that terminates in finite time and test it once I have time and DAS is responding.

@dmitrijus
Copy link
Contributor

hold
Nice!

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @dmitrijus
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

Pull request #16973 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@schneiml
Copy link
Contributor Author

schneiml commented Dec 16, 2016

@dmitrijus I added the DAS query support. Main issue is that it can take a while to get results, but that is pretty much expected. Therefore I allowed having the dataset_cfi.py file instead, but I removed it from the PR and by default DAS is queried.

Works with the default options, might need some tuning for older runs...

Bonus: cmsRun pixel_dqm_sourceclient-live_cfg.py runNumber=1 dataset=/RelValTTbar_13/CMSSW_8_1_0-PU25ns_81X_upgrade2017_realistic_v26_HLT2017-v1/GEN-SIM-DIGI-RAW or similar to run on Relval MC data (though the pixel online config needs more changes to work with MC data).

@dmitrijus
Copy link
Contributor

super!

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17204/console Started: 2017/01/09 11:12

@dmitrijus
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5bd3af0 into cms-sw:CMSSW_9_0_X Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants