Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibTracker-SiStripLorentzAngle: potential bug beginRun now called #16984

Merged
merged 1 commit into from Feb 3, 2017
Merged

CalibTracker-SiStripLorentzAngle: potential bug beginRun now called #16984

merged 1 commit into from Feb 3, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 12, 2016

because beginRun parameters were corrected to match base class to
fix clang warning hides overloaded virtual function [-Woverloaded-virtual]

because beginRun parameters were correct to match base class to
fix clang warning hides overloaded virtual function [-Woverloaded-virtual]
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

CalibTracker/SiStripLorentzAngle

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @jlagram, @gbenelli, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@mmusich
Copy link
Contributor

mmusich commented Dec 13, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16986/console Started: 2016/12/13 07:33

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16984/16986/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
  • 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFull_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

@franzoni
Copy link

please test

( the test are no longer accessible )

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17314/console Started: 2017/01/17 18:10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ghellwig
Copy link

ghellwig commented Feb 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 9c65890 into cms-sw:CMSSW_9_0_X Feb 3, 2017
@gartung gartung deleted the CalibTracker-SiStripLorentzAngle-fix-clang-warnings branch March 13, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants