Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90x L1T - remove an external data file #17016

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Dec 14, 2016

PR 90x - remove a data file introduced in merged PR #16967.
(This file is not in 80x PR #16966, so nothing to remove there.)

Description:
Remove one L1Trigger/L1TGlobal/data file that sneaked in - UGT_BASE_RS_PRESCALES_v11.xml.

This external data file is by now merged in cms-data PR cms-data/L1Trigger-L1TGlobal#7.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_9_0_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Dec 14, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17017/console Started: 2016/12/14 04:43

@rekovic
Copy link
Contributor Author

rekovic commented Dec 14, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

+1
(better just not to include these files in your pull requests at all...)

@cmsbuild cmsbuild merged commit fabc0fa into cms-sw:CMSSW_9_0_X Dec 14, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants