PhysicsTools/IsolationUtils: fix clang warning hides overloaded virtual function #17017
Conversation
…al function by changing paramenters to match base class function.
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X. It involves the following packages: PhysicsTools/IsolationUtils @cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
…ysicsTools-IsolationUtils-fix-clang-warnings
|
@Dr15Jones please test |
| @@ -47,7 +47,7 @@ class ConeAreaFunction : public ROOT::Math::ParamFunction<ROOT::Math::IParametri | |||
| virtual ROOT::Math::IGenFunction* Clone () const { return new ConeAreaFunction(*this); } | |||
|
|
|||
| protected: | |||
| void SetParameters(double* param); | |||
| void SetParameters(double const* param); | |||
There was a problem hiding this comment.
how about adding override? Same the for rest.
|
Pull request #17017 was updated. @cmsbuild, @monttj, @davidlange6 can you please check and sign again. |
|
Pull request #17017 was updated. @cmsbuild, @monttj, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
by changing paramenters to match base class function.