Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoParticleFlow/PFTracking/test: fix clang warnings in test classes #17031

Merged
merged 1 commit into from Dec 16, 2016
Merged

RecoParticleFlow/PFTracking/test: fix clang warnings in test classes #17031

merged 1 commit into from Dec 16, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 14, 2016

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @makortel, @rafaellopesdesa, @lgray, @cbernet, @bachtis this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Dec 14, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17030/console Started: 2016/12/14 17:04

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #17031 a01c7ae

Fixing Clang warning in RecoParticleFlow/PFTracking/test by deleting pointless function overloading. There should be no change in standard workflows.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_9_0_X_2016-12-14-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f819f82 into cms-sw:CMSSW_9_0_X Dec 16, 2016
@gartung gartung deleted the RecoParticleFlow-PFTracking-test-fix-clang-warnings branch December 16, 2016 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants