Pr90x l1t integration (v89.20) Mu isolation perf, EG new vars, Gen in L1TNtuple #17053
Conversation
The L1AnalysisGeneratorDataFormat was never created, leading to a segfault when used. Also made muon part functional again.
Conflicts: L1Trigger/L1TMuon/data
|
A new Pull Request was created by @rekovic for CMSSW_9_0_X. It involves the following packages: Configuration/StandardSequences @cmsbuild, @rekovic, @franzoni, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
even better, thanks
… On Dec 16, 2016, at 4:14 PM, rekovic ***@***.***> wrote:
@rekovic commented on this pull request.
In L1Trigger/L1TNtuples/plugins/L1GenTreeProducer.cc:
> @@ -92,10 +92,11 @@ L1GenTreeProducer::L1GenTreeProducer(const edm::ParameterSet& iConfig)
genParticleToken_ = consumes<reco::GenParticleCollection>(iConfig.getUntrackedParameter<edm::InputTag>("genParticleToken"));
pileupInfoToken_ = consumes<std::vector<PileupSummaryInfo> >(iConfig.getUntrackedParameter<edm::InputTag>("pileupInfoToken"));
+ l1GenData_ = new L1Analysis::L1AnalysisGeneratorDataFormat();
OK. Will switch to smart ptrs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
orp-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request will be automatically merged. |
90x - l1t-integration from v89.15 to v89.20
Mu isolation performance improvements and extrapolation eta/phi to vtx.
EG new vars (New EGamma var (HoverE) in DataFormats/L1Trigger)
Gen fix in L1TNtuple
Once approved will backport these commits onto #16966.