write a collection in JetTracksAssociatorAtCaloFace::produce before premature return

[slava77]

producers better make a product each event they are called
JetTracksAssociatorAtCaloFace didn't.
found while running on a file with products from multiple reco passes.

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_9_0_X.

It involves the following packages:

RecoJets/JetAssociationProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17094/console Started: 2016/12/17 02:17

[cmsbuild]

+1
Tested at: 1dfa050
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17063/17094/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17063/17094/summary.html

[slava77]

+1

for #17063 1dfa050

• jenkins tests pass and comparisons show no differences
• local tests in a setup where the problem occurred confirms that ak4JetTracksAssociatorAtCaloFace is present in every event after the fix

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1