tracking DQM improvements #17074

mtosi · 2016-12-19T13:34:58Z

as requested by tracking POG @VinInn @rovere
we add some plots

tracks from PV monitoring
(these tracks are selected by using the available TrackWithVertexSelector_cfi)
V0 monitoring for V0 candidates w/ lxy > 16 cm
(the V0 candidates are selected by a new EDProducer)

… pixel layer)

cmsbuild · 2016-12-19T13:35:17Z

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_0_X.

It involves the following packages:

CommonTools/RecoAlgos
DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource

@cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @hdelanno, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann, @gkasieczka, @fioriNTU, @idebruyn, @threus this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

makortel · 2016-12-19T13:44:43Z

DQM/TrackingMonitorSource/python/TrackCollections2monitor_cff.py

+from CommonTools.RecoAlgos.TrackWithVertexSelector_cfi import *
+
+trackAssociated2pvSelector = trackWithVertexSelector.clone()
+trackAssociated2pvSelector.trackWithVertexSelectorParams = cms.PSet(


TrackWithVertexSelector does not have(/read) trackWithVertexSelectorParams PSet.

What happens in TrackWithVertexSelector_cfi.py is that the contents of trackWithVertexSelectorParams are copied to trackWithVertexSelector.

makortel · 2016-12-19T13:46:44Z

DQM/TrackingMonitorSource/python/TrackCollections2monitor_cff.py

+   vertexTag    = cms.InputTag('trackingDQMgoodOfflinePrimaryVertices'),
+   timesTag     = cms.InputTag(''),
+   timeResosTag = cms.InputTag(''),
+   nVertices    = cms.uint32(0), ## how many vertices to look at before dropping the track


nVertices == 0 disables the vertex compatibility checks, i.e. only TrackWithVertexSelector::testTrack() gets called.

VinInn · 2016-12-19T16:08:28Z

@cmsbuild , please test

cmsbuild · 2016-12-19T16:08:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17110/console Started: 2016/12/19 17:09

cmsbuild · 2016-12-19T17:39:06Z

-1

Tested at: 3f47885

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17074/17110/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFull_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFull_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8.log

cmsbuild · 2016-12-19T17:39:20Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cvuosalo · 2016-12-19T23:23:19Z

CommonTools/RecoAlgos/src/VertexCompositeCandidateCollectionSelector.cc

+											      -1*((bs->position().y() - v0.vy()) + (v0.vz() - bs->position().z()) * bs->dydz()), 
+											      0 ) );
+       float lxy      = ( pv==nullptr ? -9. : displacementFromPV.perp() );
+       float lxyWRTbs = ( bs==nullptr ? -9. : displacementFromBS.perp() );


Please don't use magic numbers. Use a constant for the -9 value. Also, in lines128 and 131, it would be good to set a constant null GlobalPoint and use that.

cmsbuild · 2016-12-20T10:37:27Z

Pull request #17074 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2017-01-09T16:52:52Z

Pull request #17074 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

slava77 · 2017-01-09T18:38:24Z

@cmsbuild please test

cmsbuild · 2017-01-09T18:38:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17214/console Started: 2017/01/09 19:40

cmsbuild · 2017-01-09T20:32:02Z

+1
Tested at: 73b0317
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17074/17214/summary.html

cmsbuild · 2017-01-09T20:32:05Z

Comparison job queued.

cmsbuild · 2017-01-09T22:24:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17074/17214/summary.html

slava77 · 2017-01-10T20:21:18Z

+1

for #17074 73b0317

reco parts of this PR, related to vertexCompositeCandidateCollectionSelector look OK. It is a new module not affecting reco products
jenkins tests pass and comparisons with baseline show no differences

dmitrijus · 2017-01-11T10:40:38Z

+1

cmsbuild · 2017-01-11T10:40:52Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-01-17T10:43:59Z

+1

mtosi added 3 commits December 12, 2016 12:22

add V0 candidate selector (currently based on lxy only)

39b5960

fix

20514ff

add V0 monitoring only for candidates w/ lxy > 16 cm (after outermost…

dc8e2c9

… pixel layer)

cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 19, 2016

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Dec 19, 2016

makortel reviewed Dec 19, 2016

View reviewed changes

fix nVertices

3f47885

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2016

cmsbuild added tests-rejected and removed tests-started labels Dec 19, 2016

cmsbuild added comparison-notrun and removed comparison-pending labels Dec 19, 2016

cvuosalo reviewed Dec 19, 2016

View reviewed changes

fix, follwing suggestion/request by carl

0c6ca39

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Dec 20, 2016

fix

73b0317

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jan 9, 2017

cmsbuild added tests-started and removed tests-pending labels Jan 9, 2017

cmsbuild added tests-approved and removed tests-started labels Jan 9, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jan 9, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 10, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 11, 2017

cmsbuild added orp-approved and removed orp-pending labels Jan 17, 2017

cmsbuild merged commit 54142ef into cms-sw:CMSSW_9_0_X Jan 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tracking DQM improvements #17074

tracking DQM improvements #17074

mtosi commented Dec 19, 2016

cmsbuild commented Dec 19, 2016

makortel Dec 19, 2016

makortel Dec 19, 2016

VinInn commented Dec 19, 2016

cmsbuild commented Dec 19, 2016 •

edited

cmsbuild commented Dec 19, 2016

cmsbuild commented Dec 19, 2016

cvuosalo Dec 19, 2016

cmsbuild commented Dec 20, 2016

cmsbuild commented Jan 9, 2017

slava77 commented Jan 9, 2017

cmsbuild commented Jan 9, 2017 •

edited

cmsbuild commented Jan 9, 2017

cmsbuild commented Jan 9, 2017

cmsbuild commented Jan 9, 2017

slava77 commented Jan 10, 2017

dmitrijus commented Jan 11, 2017

cmsbuild commented Jan 11, 2017

davidlange6 commented Jan 17, 2017

tracking DQM improvements #17074

tracking DQM improvements #17074

Conversation

mtosi commented Dec 19, 2016

cmsbuild commented Dec 19, 2016

makortel Dec 19, 2016

Choose a reason for hiding this comment

makortel Dec 19, 2016

Choose a reason for hiding this comment

VinInn commented Dec 19, 2016

cmsbuild commented Dec 19, 2016 • edited

cmsbuild commented Dec 19, 2016

cmsbuild commented Dec 19, 2016

cvuosalo Dec 19, 2016

Choose a reason for hiding this comment

cmsbuild commented Dec 20, 2016

cmsbuild commented Jan 9, 2017

slava77 commented Jan 9, 2017

cmsbuild commented Jan 9, 2017 • edited

cmsbuild commented Jan 9, 2017

cmsbuild commented Jan 9, 2017

cmsbuild commented Jan 9, 2017

slava77 commented Jan 10, 2017

dmitrijus commented Jan 11, 2017

cmsbuild commented Jan 11, 2017

davidlange6 commented Jan 17, 2017

cmsbuild commented Dec 19, 2016 •

edited

cmsbuild commented Jan 9, 2017 •

edited