EventFilter-EcalRawToDigi: fix clang warning hides overloaded virtual function #17080
Conversation
… function by adding using directive and adding parameters to function calls to disambiguate from base class function call.
|
@Dr15Jones please review |
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X. It involves the following packages: EventFilter/EcalRawToDigi @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
| @@ -164,7 +164,7 @@ void DCCEBEventBlock::unpack(const uint64_t * buffer, size_t numbBytes, unsigned | |||
|
|
|||
| // Unpack SRP block | |||
| if(srChStatus_ != CH_TIMEOUT && srChStatus_ != CH_DISABLED){ | |||
| STATUS = srpBlock_->unpack(&data_,&dwToEnd_); | |||
| STATUS = srpBlock_->unpack(&data_,&dwToEnd_,SRP_NUMBFLAGS); | |||
There was a problem hiding this comment.
Why was adding the default value needed? Did it fail to compile otherwise?
There was a problem hiding this comment.
Yes. With the using statement in the header clang now see two signatures of unpack that take two parameters: one is the base class function and the other is the derived class function with one of three parameters defaulted.
There was a problem hiding this comment.
I had to do something similar for #17015
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
by adding using directive and adding parameters to function calls to disambiguate from base class function call. If the function is called without the defaulted parameter it could be interpreted as a call to the base class function.