DQM-HcalCommon+HcalTasks: fix clang warnings hides overloaded virtual function #17015

gartung · 2016-12-13T21:38:50Z

by adding using directives and also pad call to Container2D with 0's so the correct initialize function is called. Fixes these warnings:
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/ba81249bb4729771235b98cb83b6e8d8/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-13-1100/src/DQM/HcalCommon/interface/HashMapper.h:33:22: warning: 'hcaldqm::mapper::HashMapper::getHash' hides overloaded virtual functions [-Woverloaded-virtual]
virtual uint32_t getHash(HcalDetId const& did) const
^
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/ba81249bb4729771235b98cb83b6e8d8/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-13-1100/src/DQM/HcalCommon/interface/HashMapper.h:45:25: warning: 'hcaldqm::mapper::HashMapper::getName' hides overloaded virtual functions [-Woverloaded-virtual]
virtual std::string getName(HcalTrigTowerDetId const& tid) const
^
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/ba81249bb4729771235b98cb83b6e8d8/opt/cmssw/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_CLANG_X_2016-12-13-1100/src/DQM/HcalCommon/interface/HashFilter.h:44:18: warning: 'hcaldqm::filter::HashFilter::initialize' hides overloaded virtual function [-Woverloaded-virtual]
virtual void initialize(FilterType ftype, HashType htype,

… function by adding using directives and also pad call to Container2D with 0's so the correct initialize function is called.

cmsbuild · 2016-12-13T21:39:08Z

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@deguio this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

gartung · 2016-12-13T22:04:42Z

@Dr15Jones @davidlange6 This one fixes ~300 clang warnings in DQM/HcalTasks

…M-HcalCommon-Tasks-fix-clang-warnings

dmitrijus · 2016-12-15T13:22:17Z

+1

cmsbuild · 2016-12-15T13:22:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17057/console Started: 2016/12/15 15:51

cmsbuild · 2016-12-15T13:22:35Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

cmsbuild · 2016-12-15T16:46:51Z

-1

Tested at: 6192781

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17015/17057/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step5

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step5_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

8.0 step5

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step5_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

140.53 step3

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step3_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1306.0 step4

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step4_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step4

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1330.0 step4

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step4_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step4

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step4

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step4_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1003.0 step3

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step3_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

10021.0 step4

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step4_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

50202.0 step4

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step4_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

136.731 step4

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step4_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

20034.0 step4

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7/step4_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7.log

10024.0 step5

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

25202.0 step4

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

cmsbuild · 2016-12-15T16:46:53Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

gartung · 2016-12-15T18:18:39Z

Appears to be a failure caused by changes
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17015/17057/runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step4_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

cmsbuild · 2016-12-16T02:27:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17080/console Started: 2016/12/16 03:28

cmsbuild · 2016-12-16T03:47:21Z

+1
Tested at: db91155
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17015/17080/summary.html

cmsbuild · 2016-12-16T03:47:24Z

Comparison job queued.

cmsbuild · 2016-12-16T04:59:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17015/17080/summary.html

dmitrijus · 2017-01-09T10:08:05Z

+1

cmsbuild · 2017-01-09T10:08:20Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-01-10T23:21:50Z

@deguio - could you confirm these changes are correct? (some of them look like workarounds to bugs to me) Thanks-

deguio · 2017-01-17T17:36:15Z

for some reason I didn't get notified for this.
@vkhristenko is looking into this PR (thanks!) and will comment here directly.
cheers,
F.

davidlange6 · 2017-01-27T14:52:53Z

hi all - any news on this ?

vkhristenko · 2017-01-27T14:55:19Z

@davidlange6 , sorry for the delay. let's just go with that. I never personally compiled cmssw with clang, gcc only.
VK

davidlange6 · 2017-01-27T14:57:34Z

its not a matter of compilation with clange/gcc - its a question of if the code changes are ok or are covering up bugs (will be the same problem in gcc just that gcc doesn’t currently complain)

…

On Jan 27, 2017, at 6:55 AM, Viktor Khristenko ***@***.***> wrote: @davidlange6 , sorry for the delay. let's just go with that. I never personally compiled cmssw with clang, gcc only. VK — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

vkhristenko · 2017-01-27T15:18:35Z

in there I intentionally overwrite the base class method. no bugs.

for my reference, http://stackoverflow.com/questions/18515183/c-overloaded-virtual-function-warning-by-clang

Vk

davidlange6 · 2017-01-27T21:18:37Z

+1

ok, thanks

DQM-HcalCommon+HcalTasks: fix clang warnings hides overloaded virtual…

6192781

… function by adding using directives and also pad call to Container2D with 0's so the correct initialize function is called.

cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 13, 2016

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Dec 13, 2016

gartung added 2 commits December 14, 2016 09:06

Merge branch 'CMSSW_9_0_X' into DQM-HcalCommon-Tasks-fix-clang-warnings

5611dfe

Merge branch 'CMSSW_9_0_X' of https://github.com/cms-sw/cmssw into DQ…

31895eb

…M-HcalCommon-Tasks-fix-clang-warnings

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Dec 15, 2016

cmsbuild added tests-started and removed tests-pending labels Dec 15, 2016

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Dec 15, 2016

gartung closed this Dec 15, 2016

add debug=0 to initialize functions so they match number of parameters

db91155

gartung reopened this Dec 15, 2016

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2016

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2016

cmsbuild added comparison-available and removed comparison-pending labels Dec 16, 2016

gartung mentioned this pull request Dec 19, 2016

EventFilter-EcalRawToDigi: fix clang warning hides overloaded virtual function #17080

Merged

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 9, 2017

cmsbuild added orp-approved and removed orp-pending labels Jan 27, 2017

cmsbuild merged commit a509240 into cms-sw:CMSSW_9_0_X Jan 27, 2017

This was referenced Feb 20, 2017

Fix or suppress warnings related to Phase0 HE in 2017 #17335

Merged

fixing the absence of const specifiers #17579

Merged

gartung deleted the DQM-HcalCommon-Tasks-fix-clang-warnings branch March 13, 2017 18:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DQM-HcalCommon+HcalTasks: fix clang warnings hides overloaded virtual function #17015

DQM-HcalCommon+HcalTasks: fix clang warnings hides overloaded virtual function #17015

gartung commented Dec 13, 2016

cmsbuild commented Dec 13, 2016

gartung commented Dec 13, 2016

dmitrijus commented Dec 15, 2016

cmsbuild commented Dec 15, 2016 •

edited

cmsbuild commented Dec 15, 2016

cmsbuild commented Dec 15, 2016

cmsbuild commented Dec 15, 2016

gartung commented Dec 15, 2016

cmsbuild commented Dec 16, 2016 •

edited

cmsbuild commented Dec 16, 2016

cmsbuild commented Dec 16, 2016

cmsbuild commented Dec 16, 2016

dmitrijus commented Jan 9, 2017

cmsbuild commented Jan 9, 2017

davidlange6 commented Jan 10, 2017

deguio commented Jan 17, 2017

davidlange6 commented Jan 27, 2017

vkhristenko commented Jan 27, 2017

davidlange6 commented Jan 27, 2017 via email

vkhristenko commented Jan 27, 2017

davidlange6 commented Jan 27, 2017

DQM-HcalCommon+HcalTasks: fix clang warnings hides overloaded virtual function #17015

DQM-HcalCommon+HcalTasks: fix clang warnings hides overloaded virtual function #17015

Conversation

gartung commented Dec 13, 2016

cmsbuild commented Dec 13, 2016

gartung commented Dec 13, 2016

dmitrijus commented Dec 15, 2016

cmsbuild commented Dec 15, 2016 • edited

cmsbuild commented Dec 15, 2016

cmsbuild commented Dec 15, 2016

cmsbuild commented Dec 15, 2016

gartung commented Dec 15, 2016

cmsbuild commented Dec 16, 2016 • edited

cmsbuild commented Dec 16, 2016

cmsbuild commented Dec 16, 2016

cmsbuild commented Dec 16, 2016

dmitrijus commented Jan 9, 2017

cmsbuild commented Jan 9, 2017

davidlange6 commented Jan 10, 2017

deguio commented Jan 17, 2017

davidlange6 commented Jan 27, 2017

vkhristenko commented Jan 27, 2017

davidlange6 commented Jan 27, 2017 via email

vkhristenko commented Jan 27, 2017

davidlange6 commented Jan 27, 2017

cmsbuild commented Dec 15, 2016 •

edited

cmsbuild commented Dec 16, 2016 •

edited