Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in tracking MC validation plot scripts #17091

Merged
merged 1 commit into from Jan 10, 2017

Conversation

makortel
Copy link
Contributor

This PR fixes an assert-style exception in tracking MC validation plot scripts. The scripts worked with the same input in 810, so maybe there was some change in ROOT that allows these histogram to extend their x axis (leading to additional surprise-bins later). The fix is to explicitly disable the axis extension.

Thanks to @rovere for reporting the issue.

Tested in 9_0_0_pre2, no changes expected in standard workflows.

@rovere @VinInn

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 21, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17140/console Started: 2016/12/21 17:01

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f3f51eb into cms-sw:CMSSW_9_0_X Jan 10, 2017
@makortel makortel deleted the fixTrackingPlotting branch February 12, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants