New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in tracking MC validation plot scripts #17091
Conversation
@cmsbuild, please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X. It involves the following packages: Validation/RecoTrack @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
This PR fixes an assert-style exception in tracking MC validation plot scripts. The scripts worked with the same input in 810, so maybe there was some change in ROOT that allows these histogram to extend their x axis (leading to additional surprise-bins later). The fix is to explicitly disable the axis extension.
Thanks to @rovere for reporting the issue.
Tested in 9_0_0_pre2, no changes expected in standard workflows.
@rovere @VinInn