bsunanda:Run2-hcx97 Bug fixes for Hcal geometry routines

[bsunanda]

No description provided.

[bsunanda]

@cmsbuild Please test

[davidlange6]

please test
(seems the bot is ignoring this pr)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17162/console Started: 2016/12/28 10:19

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_9_0_X.

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[cmsbuild]

+1
Tested at: 06c3255
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17099/17162/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17099/17162/summary.html

[cmsbuild]

Pull request #17099 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #17099 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17164/console Started: 2016/12/28 18:21

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

Hi @bsunanda - what is the expected impact of these changes on hgcal results (eg, are those coming from 8_2_0 are affected?)

[abdoulline]

...In addition to David's question: is there any impact on Run 2 / Phase 1 ?
Ieta=29 depth > 2 seems to be affected?
I might have missed something, as actually there is no RelVal Run 2 / Phase 1 differences...

[davidlange6]

ping @bsunanda

[ianna]

@abdoulline and @davidlange6 - as discussed at ORP I was asked to look into this. No affect on Phase 0 is expected. To check the impact on Phase I one should look for cells with ieta=29 and depth=3 in order to check if their delta Eta is a double size compared to cells with ieta=29 and depth=2 or 1. So this PR does actually fix this bug.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17349/console Started: 2017/01/20 19:15

[cmsbuild]

+1
Tested at: 50917aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17099/17349/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17099/17349/summary.html

[bsunanda]

@davidlange6 @abdoulline @ianna The changes will not affect the standard physics results - the affected codes refer to functionality for some special cases only. Please integrate the code

[davidlange6]

+1