bsunanda:Run2-alca74 Make IsoTrack AlCaReco as well as tree makers to be equally useful for all possible isolation strategy #17100
Conversation
|
@cmsbuild Please test |
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_9_0_X. It involves the following packages: Calibration/HcalAlCaRecoProducers @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Comparison job queued. |
|
@mmusich Kindly approve this. |
| @@ -26,5 +25,9 @@ | |||
| ConeRadiusMIP = cms.double(14.0), | |||
| MinimumTrackP = cms.double(20.0), | |||
| MaximumEcalEnergy = cms.double(2.0), | |||
| IsolationEnergy = cms.double(10.0), | |||
| MaxTrackP = cms.double(8.0), | |||
| SlopeTrackP = cms.double(0.05090504066), | |||
There was a problem hiding this comment.
@bsunanda can you document from where does this magic number come from? Do you really need 10 digits?
There was a problem hiding this comment.
This was documented in a DN - it is the result of expanding an exponential
There was a problem hiding this comment.
@bsunanda - could you add the DN reference here so its easy to find later. Thanks
There was a problem hiding this comment.
DN-2016/029 and the magic # was log(2.5)/18. It came from a study by Marina Chadeeva to define eta dependent cut
|
we gather the selections have been changed and generally loosened. once you'll have numbers, would you be willing to report at a forthcoming AlCa/Db meeting ? Thanks. |
|
@ghellwig |
|
@franzoni Kindly accept this PR. I shall try to see how to reduce the data storage requirement (1) by using a handle which can be changed without changing the C++ code (2) by balancing event rate in barrel and endcap |
|
@franzoni Please sign this PR |
|
hello @bsunanda We agreed that we need to: . quantify the max number of GB/fb an alcareco essential for the HCAL calibration program can write =->AlCa/Db ; we agreed that the increase 30-70 GB => 1200-3000 GB per fb is not sustainable the last two topics are suitable for discussion at the AlCa/dB workshop. |
|
+1 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-started
tests-pending
labels
|
Comparison job queued. |
|
@franzoni Now we have only 2 types of isolation cut - eta dependent and a flat value. we take the larger of the two to make the cut - it was similar in the past (there were an extra flat value which was redundant) - but the net results were the same which I mentioned in the AlCaReco meeting. Can you please approve this - it is now more than 2 months old. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
+1 |
Correct for soft and eta-dependent isolation strategy. There are eta dependent isolation energy cut off versus a eta-independent cut off. The value whichever is larger is used as the cut off