add [[cms::thread_safe]] or const to statics

[gartung]

No description provided.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

add [[cms::thread_safe]] or const to statics

It involves the following packages:

FWCore/MessageLogger
FWCore/MessageService

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[cmsbuild]

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/CondFormats/PhysicsToolsObjects/src/MVAComputer.cc 
>> Building LCG reflex dict from header file src/CondFormats/PhysicsToolsObjects/src/classes.h
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/FWCore/MessageLogger/interface/MessageLogger.h:134,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/CondFormats/Common/interface/ConfObject.h:11,
                 from src/CondFormats/Common/src/classes.h:8:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/FWCore/MessageLogger/interface/MessageDrop.h:109: error: expected unqualified-id before '[' token
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/FWCore/MessageLogger/interface/MessageDrop.h:110: error: expected unqualified-id before '[' token
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/FWCore/MessageLogger/interface/MessageDrop.h:111: error: expected unqualified-id before '[' token
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/FWCore/MessageLogger/interface/MessageDrop.h:112: error: expected unqualified-id before '[' token
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/FWCore/MessageLogger/interface/MessageDrop.h:113: error: expected unqualified-id before '[' token
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-09-0200/src/CondFormats/Common/interface/ConfObject.h:11,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1711/1658/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[Dr15Jones]

The build failure means we must hide the new attribute notation, [[]], from Reflex.

[cmsbuild]

Pull request #1711 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1711/1675/summary.html