Fix randomly failing framework unit test #17119
Conversation
The test run_global_stream_one.sh includes a test to check that when using modules which share a resource that only one module runs at a time. Previously, the measurement mechanism also included TriggerResults and the source in the timing which could create false positives and fail the test. Now the test excludes those two from the measurement so the test should never see more than one module running at a time.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
The test run_global_stream_one.sh includes a test to check that
when using modules which share a resource that only one module
runs at a time. Previously, the measurement mechanism also included
TriggerResults and the source in the timing which could create
false positives and fail the test. Now the test excludes those
two from the measurement so the test should never see more than one
module running at a time.