Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to stall-monitoring service and script. #17127

Merged
merged 5 commits into from Jan 14, 2017

Conversation

knoepfel
Copy link
Contributor

@knoepfel knoepfel commented Jan 6, 2017

Script now takes advantage of information emitted at the preSourceEvent and postSourceEvent signals. In addition the script is significantly faster for creating the PDF image, and it also includes capabilities for creating a stack plot.

- Significant improvements to plotting efficiency.
- Fixes to thread accounting--not fully solved, but better.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

A new Pull Request was created by @knoepfel (Kyle Knoepfel) for CMSSW_9_0_X.

It involves the following packages:

FWCore/Concurrency
FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17201/console Started: 2017/01/06 20:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2017

@cmsbuild
Copy link
Contributor

Pull request #17127 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

@knoepfel
Copy link
Contributor Author

Most recent improvements include:

  • Checking that the supplied extension for pdf file is supported.
  • Improving the ordering of colors in the stacked plot.
  • Clearer y-axis labels.

The accounting error I thought I had encountered before no longer seems to be present. I will adjust the script if it arises again.

@Dr15Jones
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17236/console Started: 2017/01/10 21:29

@cmsbuild
Copy link
Contributor

Pull request #17127 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

@knoepfel
Copy link
Contributor Author

Assuming the tests pass, this PR is complete.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17284/console Started: 2017/01/13 18:31

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 51262a1 into cms-sw:CMSSW_9_0_X Jan 14, 2017
@knoepfel knoepfel deleted the stall-grapher branch January 17, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants